Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required to get local to mainnet testing working with Umee #776

Merged
merged 5 commits into from
May 24, 2023

Conversation

riley-stride
Copy link
Contributor

Closes: #XXX

Context and purpose of the change

Brief Changelog

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@riley-stride riley-stride marked this pull request as ready for review May 16, 2023 23:17
Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Can you make the one small change from the comment below, and then do the following to reset the default commands.sh and confirm the makefile commands work:

make start-local-to-main
make stop-local-to-main

Then push up that new commands.sh which will serve as the example


STRIDE_CHAIN_ID=local-test-1 # # DO NOT USE STRIDE MAINNET CHAIN ID! always use a new chain id by incrementing the suffix after each run
HOST_CHAIN_ID=cosmoshub-4 # chain id on the host
HOST_ENDPOINT=gaia-fleet-direct.main.stridenet.co # RPC on the host
Copy link
Collaborator

@sampocs sampocs May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HOST_ENDPOINT=gaia-fleet-direct.main.stridenet.co # RPC on the host
HOST_RPC=https://comsos-rpc.polkachu.com # RPC on the host

Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sampocs sampocs added the A:automerge Automatically merge PR once checks pass label May 24, 2023
@mergify mergify bot merged commit 936c33f into main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once checks pass T:build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants