Removed Epoch Unbonding Record's with Zero Amount #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellvish
approved these changes
Feb 16, 2023
| @@ -282,7 +282,7 @@ func (k Keeper) CleanupEpochUnbondingRecords(ctx sdk.Context, epochNumber uint64 | |||
| for _, hostZoneUnbonding := range hostZoneUnbondings { | |||
| // if an EpochUnbondingRecord has any HostZoneUnbonding with non-zero balances, we don't delete the EpochUnbondingRecord | |||
| // because it has outstanding tokens that need to be claimed | |||
| if hostZoneUnbonding.NativeTokenAmount != sdkmath.ZeroInt() { | |||
| if !hostZoneUnbonding.NativeTokenAmount.Equal(sdkmath.ZeroInt()) { | |||
|
sontrinh16
pushed a commit
to notional-labs/stride
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #609
Thanks @gloryan0829 for catching this!
Context and purpose of the change
The comparison check in the condition that removes 0-amount epoch unbonding records is stale since migrating to sdk.Ints, preventing the records from being deleted.
Brief Changelog
Author's Checklist
I have...
If skipped any of the tests above, explain.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Documentation and Release Note
Unreleasedsection inCHANGELOG.md?How is the feature or change documented?
XXXx/<module>/spec/)