Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete update status HostZoneUnbonding_EXIT_TRANSFER_QUEUE in UpdateHostZoneUnbondings function #542

Merged
merged 14 commits into from
Feb 16, 2023
Merged

Delete update status HostZoneUnbonding_EXIT_TRANSFER_QUEUE in UpdateHostZoneUnbondings function #542

merged 14 commits into from
Feb 16, 2023

Conversation

ThanhNhann
Copy link
Contributor

Closes: #525

Context and purpose of the change

HostZoneUnbonding's status EXIT_TRANSFER_QUEUE was set twice, before and after burning stTokens during UndelegateCallback so I think it should be used in SetHostZoneUnbondings instead of UpdateHostZoneUnbondings function because there is a param type of recordstypes in SetHostZoneUnbondings and the main reason is after Updatehostzone we have to set it to store

Brief Changelog

  • Delete update status of hostZoneUnbonding in UpdateHostZoneUnbondings function

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

This was referenced Dec 22, 2022
Closed
Closed
sampocs
sampocs approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice catch!

x/stakeibc/keeper/icacallbacks_undelegate.go Outdated
// * Does nothing
// If failure:
// * Reverts epoch unbonding record status
//
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, was this change done manually or from a linter? I like it either way, just wondering if I have different lint settings!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from a linter of my vs code 👨‍💻, if you think it shouldn't change, I will revert it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No don’t revert it, it looks good! Was just curious

@faddat faddat added the notional Issues that are open to be picked up by notional, if not assigned label Dec 28, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jan 12, 2023
@github-actions github-actions bot closed this Jan 18, 2023
@sampocs
Copy link
Collaborator

sampocs commented Jan 18, 2023

Open

@sampocs sampocs reopened this Jan 18, 2023
@github-actions github-actions bot removed the Stale label Jan 19, 2023
@asalzmann
Copy link
Contributor

Open

@ThanhNhann
Copy link
Contributor Author

hi @asalzmann, can you plz review and merge this pr?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Feb 16, 2023
@sampocs sampocs merged commit 0413e99 into Stride-Labs:main Feb 16, 2023
sontrinh16 pushed a commit to notional-labs/stride that referenced this pull request Mar 27, 2023
@ThanhNhann @DongLieu @faddat
Delete update status HostZoneUnbonding_EXIT_TRANSFER_QUEUE in UpdateH…
83eeeec 
…ostZoneUnbondings function (Stride-Labs#542)

Co-authored-by: DongLieu <duongduydongtq@gmail.com>
Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampocs sampocs sampocs approved these changes

Assignees
No one assigned
Labels
notional Issues that are open to be picked up by notional, if not assigned Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

solve audit: Various kinds of observations
5 participants
@ThanhNhann @sampocs @asalzmann @faddat @DongLieu