-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add max claimable tokens query #375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:docs
C:proto
dependencies
Pull requests that update a dependency file
labels
Nov 20, 2022
github-actions
bot
removed
the
dependencies
Pull requests that update a dependency file
label
Nov 20, 2022
sampocs
reviewed
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Airdrop script worked as expected. You mentioned adding a new unit test but I'm not seeing it - was that meant as a TODO?
@sampocs had forgotten to hit push on the unittest, just pushed it |
Co-authored-by: sampocs <sam@stridelabs.co>
Co-authored-by: sampocs <sam@stridelabs.co>
sampocs
approved these changes
Nov 21, 2022
sontrinh16
pushed a commit
to notional-labs/stride
that referenced
this pull request
Mar 27, 2023
## Context and purpose of the change - Add a query to get the total number of tokens a user can claim in an airdrop period - Add a setup script to run the airdrop locally (reproducibly) ## Changelog - Add `includeClaimed` arg to `TotalClaimable` query (and dependent functions) ## Testing - Add unittest I also tested this manually, by running ``` make start-docker bash scripts/airdrop.sh $STRIDE_MAIN_CMD query claim total-claimable stride stride1nf6v2paty9m22l3ecm7dpakq2c92ueyununayr "true" ``` and verifying the output ``` coins: - amount: "600000" denom: ustrd ``` using `"false"` returns ``` coins: [] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and purpose of the change
Changelog
includeClaimed
arg toTotalClaimable
query (and dependent functions)Testing
I also tested this manually, by running
and verifying the output
using
"false"
returns