Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps only #369

Merged
merged 3 commits into from
Nov 19, 2022
Merged

bumps only #369

merged 3 commits into from
Nov 19, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Nov 19, 2022

Closes: #XXX

Context and purpose of the change

  • eliminates the need for a forked cosmos-sdk
  • fixes go version to 1.19 based on validator feedback
  • cosmos-sdk v0.45.11
  • tendermint v0.34.23
  • iavl v0.19.4
  • ibc-go v3.4.0

Brief Changelog

  • yaml files were formatted on save after bumping go from 1.18 to 1.19
  • All cosmos ecosystem dependencies have been updated to their latest version

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@github-actions github-actions bot added C:CLI dependencies Pull requests that update a dependency file labels Nov 19, 2022
@github-actions github-actions bot added the T:CI label Nov 19, 2022
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the bumps! :)

@asalzmann asalzmann merged commit 384178b into main Nov 19, 2022
asalzmann added a commit that referenced this pull request Nov 27, 2022
This reverts commit 384178b.
sontrinh16 pushed a commit to notional-labs/stride that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI dependencies Pull requests that update a dependency file T:CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants