Add x/stakedym #1126
Merged
Add x/stakedym #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampocs
reviewed
Mar 6, 2024
| @@ -0,0 +1,20 @@ | |||
| // #nosec G101 | |||
| package types | |||
There was a problem hiding this comment.
verified everything but the addresses. Do you have a doc I can use for the addresses?
x/stakedym/types/msgs_test.go
Outdated
| @@ -1,950 +0,0 @@ | |||
| package types_test | |||
There was a problem hiding this comment.
did you mean to delete this file?
There was a problem hiding this comment.
No, good catch, adding back in!
riley-stride
reviewed
Mar 7, 2024
x/stakedym/types/dymension.go
Outdated
| DymensionChainId = "dymension_1100-1" | ||
| StrideToDymensionTransferChannelId = "channel-197" | ||
| DymensionNativeTokenDenom = "adym" | ||
| DymensionNativeTokenIBCDenom = "ibc/FF6C2E86490C1C4FBBD24F55032831D2415B9D7882F85C3CC9C2401D79362BEA" // #nosec G101 |
There was a problem hiding this comment.
base ❯ dymd q ibc-transfer denom-trace FF6C2E86490C1C4FBBD24F55032831D2415B9D7882F85C3CC9C2401D79362BEA
denom_trace:
base_denom: ustrd
path: transfer/channel-0
asalzmann
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds x/stakedym module, tested on local->mainnet flow (staking, unstaking, compounding).
Please note, this does not test granular authz permissions, those should be tested separately.
Also note, we will need to update addresses in
x/stakedym/types/dymension.go.Combed through each file, and made sure any reference to tia could be changed without issue. Also high-level traced through logic and think everything should function smoothly.