Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove url escape icq #1068

Merged
merged 2 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockernet/tests/integration_tests.bats
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ setup_file() {
# equal to 2 * REDEEM_AMOUNT (since there were two redemptions - one from autopilot, one here)
redemption_record_amount=$($STRIDE_MAIN_CMD q records list-user-redemption-record | grep -Fiw 'amount' | head -n 1 | grep -o -E '[0-9]+')
expected_record_minimum=$(echo "$REDEEM_AMOUNT * 2" | bc)
assert_equal "$(($redemption_record_amount > $expected_record_minimum))" "1"
assert_equal "$(($redemption_record_amount >= $expected_record_minimum))" "1"

WAIT_FOR_STRING $STRIDE_LOGS "\[REDEMPTION] completed on $HOST_CHAIN_ID"
WAIT_FOR_BLOCK $STRIDE_LOGS 2
Expand Down
3 changes: 1 addition & 2 deletions x/interchainquery/keeper/msg_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package keeper
import (
"context"
"fmt"
"net/url"
"sort"
"strings"

Expand Down Expand Up @@ -88,7 +87,7 @@ func (k Keeper) VerifyKeyProof(ctx sdk.Context, msg *types.MsgSubmitQueryRespons
var clientStateProof []*ics23.ProofSpec = tendermintClientState.ProofSpecs

// Get the merkle path and merkle proof
path := commitmenttypes.NewMerklePath([]string{pathParts[1], url.PathEscape(string(query.RequestData))}...)
path := commitmenttypes.NewMerklePath([]string{pathParts[1], string(query.RequestData)}...)
merkleProof, err := commitmenttypes.ConvertProofs(msg.ProofOps)
if err != nil {
return errorsmod.Wrapf(types.ErrInvalidICQProof, "Error converting proofs: %s", err.Error())
Expand Down
Loading