-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamically update user redemption records during unbonding #1053
Conversation
…nto v17-upgrade-handler
Co-authored-by: riley-stride <104941670+riley-stride@users.noreply.github.com>
…nto v17-upgrade-handler
Co-authored-by: sampocs <sam.pochyly@gmail.com>
61f450f
to
9151887
Compare
Co-authored-by: sampocs <sam.pochyly@gmail.com>
…nto v17-upgrade-handler
Manual testing to inspect the native_token_amount incrementing: Here's a gist that shows native_token_amount incrementing on epoch-unbonding-records upon unbonding. CMD+F for "1004" to see native_token_amount increment. Note this change aligns with the status of the record changing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests look quite solid. Covering all the functions and edge cases I can think of. If we wanted to beef them up we could test RefreshHostZoneUnbondingNativeTokenAmount
and RefreshUserRedemptionRecordNativeAmounts
more directly, but I think RefreshHostZoneUnbondingNativeTokenAmount
already has good coverage of these indirectly, as you noted.
x/stakeibc/keeper/unbonding_records_get_host_zone_unbondings_msgs_test.go
Show resolved
Hide resolved
fcd7e15
to
b08635f
Compare
Co-authored-by: sampocs <sam.pochyly@gmail.com>
Context
(See #1049 for more context)
Refactored the dynamic redemption rate during unbonding PR.
Motivation for refactoring: