Refactor threshold #105
Merged
Refactor threshold #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ninjatosba
commented
Dec 4, 2024
- The exit cancelled operation has been removed; Exit_stream will now handle these situations differently.
- A threshold state has been added under the Finalized status.
- The creator will execute Finalize_stream regardless of whether the threshold is reached or not.
orkunkl
approved these changes
Dec 6, 2024
| @@ -25,6 +25,8 @@ pub struct StreamState { | |||
| pub out_asset: Coin, | |||
| /// Status info of the stream | |||
| pub status_info: StatusInfo, | |||
| /// Threshold amount of the stream | |||
| pub threshold: Option<Uint256>, | |||
There was a problem hiding this comment.
Just pulling attention to decide if this should go to Streamİnfo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.