Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https & scrolling issue #96

Closed
ranvirrai1987 opened this issue Apr 4, 2015 · 18 comments
Closed

https & scrolling issue #96

ranvirrai1987 opened this issue Apr 4, 2015 · 18 comments
Assignees

Comments

@ranvirrai1987
Copy link

Hi there,

Not a developer myself but thought i'd put this issue out there for it to be looked into.

There seems to be an issue when using https on infinite scroll pages. What happens is that the next page doesn't load. I've singled this out to the Magento pagination which uses http for the next pages (on https page). This causes a mixed content issue, please see here: https://developer.mozilla.org/en-US/docs/Security/MixedContent .

I think the above causes the issue but you would probably know more on this than me. Is there a solution to this?

Thanks,

Ranvir

@ranvirrai1987
Copy link
Author

Just to add,

This issue is only likely to occur when:

You go to a https page such as 'my account' or 'cart' and then use search which would take you through the https handle

or

If you plan to use the https handle for all pages or google picks up the https handle which redirects people to https pages.

Thanks,

Ranvir

@janmyszkier
Copy link

@ranvirrai1987 this is confirmed ,the problem relies in history.replaceState used in infiniteajaxscroll library being used, I'll contact the developer to provide the fix, as I guess more people using it have this problem.

@ranvirrai1987
Copy link
Author

Hi Janmyszkier,

That would be good, thank you. It would certainly help users of Infinite Scroll, especially if they intend to run everything through https as a means to use the new chrome browser notifications. Will bring the Magento user closer to that goal.

Thanks,

Ranvir

@janmyszkier
Copy link

@ranvirrai1987 : try this fork:
https://github.com/janmyszkier/Magento-InfiniteScroll/tree/protocol_fix
and let me know if it works for you too, will issue pull request then

@ranvirrai1987
Copy link
Author

Thanks for the fork. I will have to get my web developer to test this out for me but I will let you know as soon as possible.

Thanks,

Ranvir

@janmyszkier
Copy link

@ranvirrai1987 : any news from the developer?

@ranvirrai1987
Copy link
Author

Hi @janmyszkier. Sorry for the late reply, I haven't had time to test this with the developer yet as I have been focused on the running of my store. I will try have this looked into sometime soon, but I will be in contact to let you know.

@gsomoza
Copy link
Member

gsomoza commented May 28, 2015

@damian-pastorini could you check @janmyszkier 's fork, make sure everything works well, and if so release a new version of the extension with the fix?

@damian-pastorini
Copy link
Contributor

@janmyszkier could you create a PR for this please? Thanks!

@janmyszkier
Copy link

@damian-pastorini : #117

@onepack
Copy link

onepack commented Jan 12, 2016

I have an issue with the module when I make the whole frontend https.
Since then The scroll doesn't load the 2nd page anymore.
I get mixed content warnings on loading the second page.

Error: Blocked loading mixed active content "http://www.domain.com/food-supplements.html?p=2"
Source File: https://www.domain.com/food-supplements.html
Line: 5

@gsomoza
Copy link
Member

gsomoza commented Jan 13, 2016

@damian-pastorini could you review the PR and merge asap so we can fix this?

damian-pastorini added a commit that referenced this issue Jan 13, 2016
@damian-pastorini
Copy link
Contributor

Fixed in #131

damian-pastorini added a commit that referenced this issue Jan 13, 2016
@damian-pastorini
Copy link
Contributor

Merged.

@damian-pastorini
Copy link
Contributor

The new extension version was also uploaded to connect:
https://www.magentocommerce.com/magento-connect/strategery-infinitescroll.html

@ranvirrai1987 , @onepack you can download the fix and test.
I'm closing this issue but if you need we could re-open it.

Thanks!

@gsomoza
Copy link
Member

gsomoza commented Jan 13, 2016

FYI it might take a few days until the new version is approved in Magento Connect (looks like they changed the process recently). Meanwhile you can download it from Github by going to the releases page and getting the "Latest release" marked in green (v3.2.2 as of this writing).

@onepack
Copy link

onepack commented Jan 13, 2016

I have installed the patched version from github. The mixed content warning is gone when scrolling down the page but... it still doesn't work. It just hangs in all browsers on the first set of products.
Cleared all cache types even reindexed to be sure but with no result.

I disabled https again for the category pages and then the module comes back to life.

@damian-pastorini
Copy link
Contributor

@onepack could you give us an URL where we can take a quick look?

Some considerations you should have:

  • If you have a theme installed make sure that only one jQuery instance is included.
  • If you have a theme installed make sure that all the selectors are properly configured in the System / Configuration / InfiniteScroll area.
  • Check the System / Configuration / Catalog / Frontend area to see the page limits are properly set to the amount of products you have.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants