-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https & scrolling issue #96
Comments
Just to add, This issue is only likely to occur when: You go to a https page such as 'my account' or 'cart' and then use search which would take you through the https handle or If you plan to use the https handle for all pages or google picks up the https handle which redirects people to https pages. Thanks, Ranvir |
@ranvirrai1987 this is confirmed ,the problem relies in history.replaceState used in infiniteajaxscroll library being used, I'll contact the developer to provide the fix, as I guess more people using it have this problem. |
Hi Janmyszkier, That would be good, thank you. It would certainly help users of Infinite Scroll, especially if they intend to run everything through https as a means to use the new chrome browser notifications. Will bring the Magento user closer to that goal. Thanks, Ranvir |
@ranvirrai1987 : try this fork: |
Thanks for the fork. I will have to get my web developer to test this out for me but I will let you know as soon as possible. Thanks, Ranvir |
@ranvirrai1987 : any news from the developer? |
Hi @janmyszkier. Sorry for the late reply, I haven't had time to test this with the developer yet as I have been focused on the running of my store. I will try have this looked into sometime soon, but I will be in contact to let you know. |
@damian-pastorini could you check @janmyszkier 's fork, make sure everything works well, and if so release a new version of the extension with the fix? |
@janmyszkier could you create a PR for this please? Thanks! |
I have an issue with the module when I make the whole frontend https. Error: Blocked loading mixed active content "http://www.domain.com/food-supplements.html?p=2" |
@damian-pastorini could you review the PR and merge asap so we can fix this? |
Fixed in #131 |
- Fix for issue #96 in GitHub.
Merged. |
The new extension version was also uploaded to connect: @ranvirrai1987 , @onepack you can download the fix and test. Thanks! |
FYI it might take a few days until the new version is approved in Magento Connect (looks like they changed the process recently). Meanwhile you can download it from Github by going to the releases page and getting the "Latest release" marked in green (v3.2.2 as of this writing). |
I have installed the patched version from github. The mixed content warning is gone when scrolling down the page but... it still doesn't work. It just hangs in all browsers on the first set of products. I disabled https again for the category pages and then the module comes back to life. |
@onepack could you give us an URL where we can take a quick look? Some considerations you should have:
Thanks! |
Hi there,
Not a developer myself but thought i'd put this issue out there for it to be looked into.
There seems to be an issue when using https on infinite scroll pages. What happens is that the next page doesn't load. I've singled this out to the Magento pagination which uses http for the next pages (on https page). This causes a mixed content issue, please see here: https://developer.mozilla.org/en-US/docs/Security/MixedContent .
I think the above causes the issue but you would probably know more on this than me. Is there a solution to this?
Thanks,
Ranvir
The text was updated successfully, but these errors were encountered: