Patching ShouldDeleteFromName for MSM (artie-labs#1126)

Stitch-Money · Jan 30, 2025 · b3b16f9 · b3b16f9
1 parent 54669f7
commit b3b16f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/destination/ddl/expiry.go b/lib/destination/ddl/expiry.go
@@ -20,7 +20,12 @@ func ShouldDeleteFromName(name string) bool {
 		return false
 	}
 
-	unix, err := strconv.Atoi(suffixParts[2])
+	part := suffixParts[2]
+	if part == "msm" {
+		return false
+	}
+
+	unix, err := strconv.Atoi(part)
 	if err != nil {
 		slog.Error("Failed to parse unix string",
 			slog.Any("err", err),

diff --git a/lib/destination/ddl/expiry_test.go b/lib/destination/ddl/expiry_test.go
@@ -19,6 +19,7 @@ func TestShouldDeleteFromName(t *testing.T) {
 			"transactions",
 			fmt.Sprintf("future_tbl___artie_suffix_%d", time.Now().Add(constants.TemporaryTableTTL).Unix()),
 			fmt.Sprintf("future_tbl___notartie_%d", time.Now().Add(-1*time.Hour).Unix()),
+			fmt.Sprintf("%s_foo_msm", constants.ArtiePrefix),
 		}
 
 		for _, tblToNotDelete := range tablesToNotDrop {