Add --pids-limit option, to prevent fork bomb in sandbox. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laixintao
commented
Jul 18, 2019
| # Allow user process to fork | ||
| #'canfork': False, | ||
| # Limiting the maximum number of user processes in Linux is tricky. | ||
| # http://unix.stackexchange.com/questions/55319/are-limits-conf-values-applied-on-a-per-process-basis |
There was a problem hiding this comment.
Note that I delete old comments here.
|
Is this test case still necessary? https://github.com/StepicOrg/epicbox/pull/9/files#diff-54f2a123f023d5a32d51df5a31f3be76L258 |
|
ping @psviderski |
psviderski
reviewed
Jul 23, 2019
psviderski
approved these changes
Jul 24, 2019
Co-Authored-By: Pavel Sviderski <pavel@canva.com>
Co-Authored-By: Pavel Sviderski <pavel@canva.com>
|
Hi, @psviderski Can you bump a new version and update to pypi? |
|
Sure, bumped version to 1.1.0 and published to PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8