Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for .NET 6 #1317

Merged
merged 11 commits into from
Jul 2, 2024
Merged

Remove support for .NET 6 #1317

merged 11 commits into from
Jul 2, 2024

Conversation

bart-vmware
Copy link
Member

Description

This PR removes multi-targeting against .NET 6. This means that from now on, Steeltoe requires .NET 8 or higher.
Aside from that, several small refactorings were applied. See the commit messages for details.

Closes #1249
Closes #1123

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Jul 2, 2024
@bart-vmware
Copy link
Member Author

/azp run Steeltoe.All

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bart-vmware
Copy link
Member Author

/azp run cleanup-code

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

sonarqubecloud bot commented Jul 2, 2024

Copy link

Code cleanup successfully reformatted files, but there were no changes to push.

@bart-vmware bart-vmware marked this pull request as ready for review July 2, 2024 10:25
@bart-vmware bart-vmware requested a review from TimHess July 2, 2024 10:25
@TimHess TimHess added this to the 4.0.0-m1 milestone Jul 2, 2024
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart-vmware bart-vmware merged commit 22615b8 into main Jul 2, 2024
17 checks passed
@bart-vmware bart-vmware deleted the drop-net60 branch July 2, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IHostApplicationBuilder overloads for .NET 8 Add IServiceCollection extension methods to enable Steeltoe
2 participants