Pretend to be xterm if Windows console supports ansi #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
|
Can I at least get a yes/no/maybe on this one? |
|
Sorry, this fell off my radar. Instead of importing the xterm definitions like this, couldn't you set the name to "xterm-256color" and then fallback on the |
|
(please do bug me when I don't respond) |
Windows people seem to be fine with this: microsoft/WSL#1446 I still think a precise terminfo file with the list of supported sequences documented in the below link would be ideal: https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences But I didn't find such a file. And I don't know how to generate one easily. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
74ad148 to
f4400b1
Compare
|
Done. Although this is not ideal, as the fallback definition is too basic. |
876b1ae to
67f1b94
Compare
And rename to `supports_ansi`.
67f1b94 to
67a1d78
Compare
|
@MoSal thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows people seem to be fine with this:
microsoft/WSL#1446
I still think a precise terminfo file with the list of
supported sequences documented in the below link would be ideal:
https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences
But I didn't find such a file. And I don't know how to generate
one easily.
A copy of xterm-256color terminfo file is included at compile-time.I copied it from ncurses 6.1.
With this commit, term should be on par with ansi_term for Windows 10users.
Edited to fallback to a basic ANSI terminal.