tempfile 3.17 compile failed while using windows-sys 0.52

[Xuanwo]

Hi, @Stebalien, thank you for the maintenance. I found that the latest tempfile 3.17 failed to compile when using windows-sys 0.52.

The error message:

error[E0308]: mismatched types
   --> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tempfile-3.17.0\src\file\imp\windows.rs:34:13
    |
33  |         if SetFileInformationByHandle(
    |            -------------------------- arguments to this function are incorrect
34  |             f.as_raw_handle(),
    |             ^^^^^^^^^^^^^^^^^ expected `isize`, found `*mut c_void`
    |
    = note:     expected type `isize`
            found raw pointer `*mut c_void`
note: function defined here
   --> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\windows-sys-0.52.0\src\Windows\Win32\Storage\FileSystem\mod.rs:607:106
    |
607 | ::windows_targets::link!("kernel32.dll" "system" #[doc = "Required features: `\"Win32_Foundation\"`"] fn SetFileInformationByHandle(hfile...
    |                                                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `tempfile` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

The commit that breaks the build: 461369f

[Stebalien]

Ah... crap. Thanks for the report. Fixed in 3.17.1.

Our of curiosity, is there any reason you can't upgrade to windows-sys 0.59? If I'm going to keep support for windows-sys 0.52, I'm probably going to need to figure out a good way to test multiple windows-sys versions in CI which isn't going to be pretty. I'd prefer to move to 0.59 entirely.

[Xuanwo]

Thank you for the quick fix!

Our of curiosity, is there any reason you can't upgrade to windows-sys 0.59?

Sadly, I'm not a direct user of either tempfile or windows-sys. I happen to rely on them through my dependency tree (I'm guessing it's from tonic or prost). So it's not something I can control.

[Stebalien]

Hm. Yeah, quite a few packages depend on 0.52 and haven't updated yet. Oh well.