WebAPI: Treat the args dictionary as immutable #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
reviewed
Jun 13, 2021
xPaw
reviewed
Jun 13, 2021
| } | ||
|
|
||
|
|
||
| var urlBuilder = new StringBuilder(); | ||
| var paramBuilder = new StringBuilder(); |
There was a problem hiding this comment.
Is HttpValueCollection only in ASP? If .NET's uri/querystring stuff can be used, all this custom escaping code could be removed.
There was a problem hiding this comment.
It seems to be an internal class only in both .NET Framework and Core, and does not appear as an available API anywhere on MS docs site. HttpUtility can parse but not build. FormUrlEncoded content can build but it requires having a full IEnumerable of all the values upfront, and is async.
voided
approved these changes
Jun 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on from #992 by avoiding making any changes to the arguments dictionary in the first place.
I've rewritten the flow of the HTTP request builder function so that instead of updating the dictionary and then transforming the dictionary into text, we write out the text values directly, and then copy over the existing dictionary values.
cc/ @JustArchi @xPaw