Add ParentalSettings to LoggedOnCallback #707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've verified that this works properly, and it's a big help for those apps that want/need to interpret those settings, for example in order to determine if
ParentalSettings.is_enabled
.I could expose
resp.parental_settings
alone and expect from the consumer to do the deserialization himself, but I believe that we can aid him a little since there is nothing else he should be doing with that data anyway. Let me know if there is anything you'd change in this implementation.Thank you in advance for considering this PR.