Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParentalSettings to LoggedOnCallback #707

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Add ParentalSettings to LoggedOnCallback #707

merged 2 commits into from
Aug 16, 2019

Conversation

JustArchi
Copy link
Contributor

I've verified that this works properly, and it's a big help for those apps that want/need to interpret those settings, for example in order to determine if ParentalSettings.is_enabled.

I could expose resp.parental_settings alone and expect from the consumer to do the deserialization himself, but I believe that we can aid him a little since there is nothing else he should be doing with that data anyway. Let me know if there is anything you'd change in this implementation.

Thank you in advance for considering this PR.

@codecov-io
Copy link

Codecov Report

Merging #707 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   24.38%   24.36%   -0.03%     
==========================================
  Files          89       89              
  Lines        8800     8808       +8     
  Branches      742      743       +1     
==========================================
  Hits         2146     2146              
- Misses       6522     6530       +8     
  Partials      132      132
Impacted Files Coverage Δ
...t2/SteamKit2/Steam/Handlers/SteamUser/Callbacks.cs 2.89% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7e495...c243179. Read the comment docs.

@yaakov-h yaakov-h merged commit 38dd2fd into SteamRE:master Aug 16, 2019
@JustArchi JustArchi deleted the archi-parental branch August 16, 2019 09:20
@yaakov-h yaakov-h added this to the 2.3.0 milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants