Improve GameID support for mods and shortcuts #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
=========================================
+ Coverage 22.43% 23.1% +0.66%
=========================================
Files 85 85
Lines 8655 8673 +18
Branches 717 719 +2
=========================================
+ Hits 1942 2004 +62
+ Misses 6588 6537 -51
- Partials 125 132 +7
Continue to review full report at Codecov.
|
yaakov-h
reviewed
Oct 25, 2018
SteamKit2/SteamKit2/Types/GameID.cs
Outdated
| { | ||
| AppID = nAppID; | ||
| AppType = GameType.GameMod; | ||
| ModID = BitConverter.ToUInt32(CryptoHelper.CRCHash(System.Text.Encoding.ASCII.GetBytes(modPath)), 0); |
There was a problem hiding this comment.
BitConverter.ToUInt32(CryptoHelper.CRCHash
So we calculate an int, convert it to bytes, and then convert it back to an int?
|
Thanks. I've switched to Crc32 now. I forgot that was even there. I also changed to UTF8 encoding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for initializing GameIDs for mods and shortcuts.