Allow DuplicateRequest in SendSteamGuardCodeAsync
#1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. What happens if authentication doesn't succeed on the next poll, but does something else (e.g. fails)? Does that just get handed as normal? |
|
Polling will throw for any eresult that isn't OK, yeah. |
JustArchi
suggested changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuplicateRequesthappens when accepting the prompt in the mobile app, and then trying to send guard code here, do not throw on it here because authentication will succeed on the next poll.This makes it easier for users because even if 2FA code is asked, Steam will send a confirmation prompt to the app regardless.
cc @JustArchi