forked from kubeflow/kubeflow
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve kfctl semantics and ability to rerun app.yaml (kubeflow#4275)
* Improve kfctl semantics and ability to rerun app.yaml * Related to kubeflow/kfctl#49 * Delete NewKfapp its not being called from anywhere. Refactor NewLoadKfAppFromURI and LoadKfAppCfgFile * We should only call CreateCfgFile and do the directory check if using a remote URI * For a local path we already have an appfile so we don't need to recreate the CreateCfgFile * Calling CreateCfgFile for local paths was a major source of friction because it ends up checking if the directory is empty. * But when invoking kfctl on a local file we don't need to check if the directory is empty because we can assume that's the correct ${KFAPP}. * Once we have a local config file we can treat the two cases the same * Fix error propogation in apply.go; if BuildKfAppFromURI returns an error we want to return that error so it ends up being printed out. Otherwise we just print out kfApp is nil and swallow the error. * Improve the error message for project, zone, and config not being set by providing the appropriate gcloud command. * Update kf_is_ready_test.py to try to figure out why things are failing.
- Loading branch information
1 parent
9a8a9f7
commit 3b27111
Showing
4 changed files
with
90 additions
and
131 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters