Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] reset context start time for each hyper query job's sql #56196

Merged

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Feb 24, 2025

Why I'm doing:

since we have merged both full and sample statistics collecting to partition level and made a big refactor on it. so if the table has a lot of partition and columns, we may collect this table for a long time. this may cause timeout of queue pending queue.
com.starrocks.common.StarRocksException: Failed to allocate resource to query: pending timeout [300s], you could modify the session variable [query_queue_pending_timeout_second] to pending more time

What I'm doing:

reset context start time for each hyper query job

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: stephen <stephen5217@163.com>
@stephen-shelby stephen-shelby requested a review from a team as a code owner February 24, 2025 03:24
@stephen-shelby stephen-shelby changed the title [UT] reset context start time for each hyper query job [BugFix] reset context start time for each hyper query job Feb 24, 2025
@stephen-shelby stephen-shelby changed the title [BugFix] reset context start time for each hyper query job [BugFix] reset context start time for each hyper query job's sql Feb 24, 2025
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/statistic/hyper/HyperQueryJob.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@murphyatwork murphyatwork merged commit 6a6102b into StarRocks:main Feb 24, 2025
92 of 99 checks passed
@stephen-shelby stephen-shelby deleted the fix_stats_hyper_start_time branch February 24, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants