Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] use StmtExecutor::execute to forward statement on follower #56160

Merged

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Feb 21, 2025

Why I'm doing:

What I'm doing:

Currently we're using StmtExecutor::handleDMLStmt which doesn't forward the DML to leader. It should be replaced with StmtExecutor::execute.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: Murphy <mofei@starrocks.com>
@murphyatwork murphyatwork requested a review from a team as a code owner February 21, 2025 08:53
Signed-off-by: Murphy <mofei@starrocks.com>
gengjun-git
gengjun-git previously approved these changes Feb 21, 2025
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: Murphy <mofei@starrocks.com>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 13 / 16 (81.25%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/statistic/StatisticUtils.java 6 9 66.67% [108, 109, 111]
🔵 com/starrocks/load/pipe/filelist/RepoExecutor.java 7 7 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@murphyatwork murphyatwork enabled auto-merge (squash) February 24, 2025 05:25
@murphyatwork murphyatwork merged commit b358399 into StarRocks:main Feb 24, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants