Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix complex expression partition prune #56143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Feb 21, 2025

Why I'm doing:

All partition expressions and their children must be monotonic functions. Other functions only support cast.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@mergify mergify bot assigned meegoo Feb 21, 2025
@meegoo meegoo force-pushed the fix_list_partition_prune branch from fd027ef to 5ad27a7 Compare February 21, 2025 03:39
@meegoo meegoo enabled auto-merge (squash) February 21, 2025 03:40
@github-actions github-actions bot added the 3.4 label Feb 21, 2025
@meegoo meegoo force-pushed the fix_list_partition_prune branch from 5ad27a7 to da3706d Compare February 21, 2025 08:29
@meegoo meegoo requested a review from a team as a code owner February 21, 2025 08:29
@meegoo meegoo changed the title [UT] Add some partition prune test case [BugFix] Fix complex expression partition prune Feb 21, 2025
Signed-off-by: meegoo <meegoo.sr@gmail.com>
@meegoo meegoo force-pushed the fix_list_partition_prune branch from da3706d to 92b4ac0 Compare February 21, 2025 08:48
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 8 / 9 (88.89%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/ScalarOperatorEvaluator.java 8 9 88.89% [225]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant