Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Paimon view #56058

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

zyl891229
Copy link
Contributor

@zyl891229 zyl891229 commented Feb 19, 2025

Why I'm doing:

Paimon has supported view to Hive Catalog
apache/paimon#4340

What I'm doing:

Implement Paimon view in Starrocks, includes the following:

  1. Support create/replace/drop Paimon view;
  2. Support show/desc Paimon view;
  3. Support read Paimon view;

Fixes #56080

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

add hms client impl

Signed-off-by: zyl891229 <zyl891229@hotmail.com>
@zyl891229 zyl891229 requested review from a team as code owners February 19, 2025 11:19
@wanpengfei-git wanpengfei-git requested a review from a team February 19, 2025 11:20
Signed-off-by: zyl891229 <zyl891229@hotmail.com>
Signed-off-by: zyl891229 <zyl891229@hotmail.com>
Signed-off-by: zyl891229 <zyl891229@hotmail.com>
Signed-off-by: zyl891229 <zyl891229@hotmail.com>
Copy link

[FE Incremental Coverage Report]

fail : 74 / 120 (61.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/PaimonView.java 6 13 46.15% [37, 39, 40, 43, 44, 46, 47]
🔵 com/starrocks/connector/ColumnTypeConverter.java 22 46 47.83% [619, 621, 623, 625, 627, 629, 635, 636, 638, 642, 643, 644, 647, 648, 649, 652, 653, 654, 655, 656, 657, 658, 659, 662]
🔵 com/starrocks/qe/ShowExecutor.java 1 2 50.00% [795]
🔵 com/starrocks/connector/paimon/PaimonMetadata.java 30 42 71.43% [116, 117, 118, 119, 121, 137, 138, 148, 155, 158, 159, 283]
🔵 com/starrocks/connector/paimon/PaimonApiConverter.java 8 10 80.00% [27, 34]
🔵 com/starrocks/catalog/Table.java 3 3 100.00% []
🔵 com/starrocks/sql/analyzer/AstToStringBuilder.java 4 4 100.00% []

Signed-off-by: zyl891229 <zyl891229@hotmail.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported Paimon view to Hive Catalog
4 participants