Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added WidgetProps #69

Merged
merged 19 commits into from
Feb 5, 2022
Merged

Added WidgetProps #69

merged 19 commits into from
Feb 5, 2022

Conversation

MrGVSV
Copy link
Collaborator

@MrGVSV MrGVSV commented Feb 1, 2022 •
edited
Loading

Added WidgetProps and its derive macro, according to RFC 1: #56.

Tasks:

  • Add WidgetProps
  • Add derive macro
  • Integrate with Widget (likely requires updating the rest of the codebase to account for it)

@MrGVSV MrGVSV requested a review from StarArawn February 1, 2022 18:54
@MrGVSV MrGVSV self-assigned this Feb 1, 2022
MrGVSV added 2 commits February 1, 2022 16:04
@MrGVSV
Merge remote-tracking branch 'upstream/main' into widget-props
7f15e77
@MrGVSV
Integrated WidgetProps
80f97b8 
Also added trait bounds to Widget since its trait object has been replaced by
BaseWidget.
MrGVSV and others added 3 commits February 3, 2022 12:12
@MrGVSV
Integrated props into functional components
61bde54 
This code doesn't work though. Running it shows that widgets are not
aligned/sized properly anymore. Will need fixing.
@StarArawn
DPI should be fixed.
3591320
@MrGVSV
Removed need for derivative on widget props
ab781b7
StarArawn
StarArawn requested changes Feb 4, 2022
View reviewed changes
Copy link
Owner

@StarArawn StarArawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good just a couple small things!

kayak_core/src/children.rs Outdated Show resolved Hide resolved
kayak_render_macros/src/function_component.rs Show resolved Hide resolved
kayak_render_macros/src/lib.rs Show resolved Hide resolved
src/widgets/background.rs Outdated Show resolved Hide resolved
src/widgets/background.rs Show resolved Hide resolved
MrGVSV added 9 commits February 4, 2022 13:06
@MrGVSV
Moved Arc into constructor
b858569
@MrGVSV
Added widget_props attribute macro
5bca7d2
@MrGVSV
Revert "Added widget_props attribute macro"
de98751 
This reverts commit 5bca7d2.
@MrGVSV
Removed naming check
8c4cbcc 
Props no longer need to be named "<Widget Name>Props"
@MrGVSV
Children name is now configurable
13867b7 
Added WidgetProps::set_children(...) in order to achieve this
@MrGVSV
Fix warnings
a16b05f
@MrGVSV
Changed rsx props ident
6b4b7d2 
This allows copy values to be used directly from props in rsx (i.e.
`props.copy_value`)
@MrGVSV
Updated examples to use props
2e73497
@MrGVSV
Formatting
f23a44a
@MrGVSV MrGVSV marked this pull request as ready for review February 4, 2022 22:23
@MrGVSV MrGVSV requested a review from StarArawn February 4, 2022 23:24
@StarArawn StarArawn merged commit 25dbfc8 into main Feb 5, 2022
@StarArawn StarArawn deleted the widget-props branch February 5, 2022 17:24
@MrGVSV MrGVSV mentioned this pull request Feb 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarArawn StarArawn StarArawn approved these changes

Assignees

@MrGVSV MrGVSV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrGVSV @StarArawn