Remove redundant time property #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73d84c4 to
5a87801
Compare
ChristopherBiscardi
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #575
I think that this code predates time generally being available to bevy shaders in
globals.We can accomplish the same thing using Bevy's built-in time. This was only being used in
bevy_ecs_tilemapfor animation.I am having trouble imagining a legit scenario where users could have been using
SecondsSinceStartupand they couldn't accomplish whatever they were doing through less janky means. So I don't think this is likely to be breaking anyone's stuff.The padding is no longer necessary as the resulting struct is now 16 byte aligned.
Testing
Tested the
animationexample on