Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev tool setup script to address Firebase emulator error #95

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

vishnuravi
Copy link
Member

@vishnuravi vishnuravi commented Jan 7, 2025

Update dev tool setup script to address Firebase emulator error

♻️ Current situation & Problem

If the development tool setup script is run in a directory without a firebase.json file (i.e. outside of the Spezi Template Application repository) it throws an error when attempting to test the Firebase emulator suite. As this script installs tools that are independent of the Spezi Template Application itself, it should be able to run completely on its own.

⚙️ Release Notes

This PR adds a step in the setup script to create a temporary firebase.json if one does not exist before testing the firebase emulator suite. The file is removed before the script exits.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@vishnuravi vishnuravi changed the title Write firebase.json file before launching firebase emulator if needed Update setup script to address emulator error Jan 7, 2025
@vishnuravi vishnuravi changed the title Update setup script to address emulator error Update setup script to address Firebase emulator error Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.73%. Comparing base (630c1b7) to head (54afc9c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          21       21           
  Lines         693      693           
=======================================
  Hits          601      601           
  Misses         92       92           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630c1b7...54afc9c. Read the comment docs.

@vishnuravi vishnuravi changed the title Update setup script to address Firebase emulator error Update dev tool setup script to address Firebase emulator error Jan 7, 2025
@vishnuravi vishnuravi merged commit 5ea6670 into main Jan 7, 2025
9 of 10 checks passed
@vishnuravi vishnuravi deleted the update/setup-script branch January 7, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants