-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Workflow Concurrency #92
Conversation
@Supereg It seems like the license tests are failing due to the Account sheet showing a loading state when selecting the account profile in the relevant UI test. It seems like this a bit of a flakey behavior; wondering if we have any ideas how we might be able to stabilize this a bit so we don't have to re-run tests. I could observe some of that behavior in the UI test recordings in the latest runs. |
…heet presentation
The problem there was our test account setup, that kicked in exactly when we contributions tests opened the account sheet. Our default behavior after signup for the TemplateApp |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 86.92% 86.73% -0.19%
==========================================
Files 21 21
Lines 688 693 +5
==========================================
+ Hits 598 601 +3
- Misses 90 92 +2
Continue to review full report in Codecov by Sentry.
|
Nice; thank you for the fix @Supereg! Feel free to merge the PR once all the reasonable tests are passing. |
Fix Workflow Concurrency
♻️ Current situation & Problem
${{ github.workflow }}
seems to be inherited from the parent workflow as noted in https://github.com/orgs/community/discussions/30708⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: