Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Workflow Concurrency #92

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Fix Workflow Concurrency #92

merged 5 commits into from
Nov 18, 2024

Conversation

PSchmiedmayer
Copy link
Member

Fix Workflow Concurrency

♻️ Current situation & Problem

⚙️ Release Notes

  • Adds concrete names for the concurrency groups.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the bug Something isn't working label Nov 13, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Nov 13, 2024
@PSchmiedmayer
Copy link
Member Author

@Supereg It seems like the license tests are failing due to the Account sheet showing a loading state when selecting the account profile in the relevant UI test. It seems like this a bit of a flakey behavior; wondering if we have any ideas how we might be able to stabilize this a bit so we don't have to re-run tests. I could observe some of that behavior in the UI test recordings in the latest runs.

@Supereg
Copy link
Member

Supereg commented Nov 18, 2024

@Supereg It seems like the license tests are failing due to the Account sheet showing a loading state when selecting the account profile in the relevant UI test. It seems like this a bit of a flakey behavior; wondering if we have any ideas how we might be able to stabilize this a bit so we don't have to re-run tests. I could observe some of that behavior in the UI test recordings in the latest runs.

The problem there was our test account setup, that kicked in exactly when we contributions tests opened the account sheet. Our default behavior after signup for the TemplateApp AccountSetup sheet is to dismiss the sheet again (also because this view is presented for the accountRequired modifier). I made the change that we disable this automatic dismiss when the presentation was user initiated. For example, if the user decides to open the Account Sheet themselves and signs in, we won't dismiss the sheet but show the AccountOverview.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (ea08d6d) to head (c6c5cd9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
TemplateApplication/Account/AccountSheet.swift 42.86% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   86.92%   86.73%   -0.19%     
==========================================
  Files          21       21              
  Lines         688      693       +5     
==========================================
+ Hits          598      601       +3     
- Misses         90       92       +2     
Files with missing lines Coverage Δ
TemplateApplication/HomeView.swift 100.00% <100.00%> (ø)
TemplateApplication/Account/AccountSheet.swift 69.05% <42.86%> (-1.22%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea08d6d...c6c5cd9. Read the comment docs.

---- 🚨 Try these New Features:

@PSchmiedmayer
Copy link
Member Author

Nice; thank you for the fix @Supereg! Feel free to merge the PR once all the reasonable tests are passing.

@Supereg Supereg merged commit 70706eb into main Nov 18, 2024
8 of 10 checks passed
@Supereg Supereg deleted the fixWorkflowConcurrency branch November 18, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants