Simplify and cleanup template app #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSchmiedmayer
approved these changes
Jul 3, 2024
|
I adjusted some of the timeout values in the Fastfile as they were continuously hit by the build jobs. Specifically for CodeQL this should save like 5 minutes (which isn't a lot for the whopping 30-40 minutes build time). Do you think it is possible to offload compilation to our custom runners (e.g., upload derived data as a build artifact and just download it for the CodeQL job). Or does the CodeQL swift extractor inject itself into the build process? Can't quite find any good resources for how exactly the swift support is achieved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and cleanup template app
♻️ Current situation & Problem
This PR tries to do some housekeeping for the template app. Refer to the release notes for a list of changes.
⚙️ Release Notes
@AppStorage.PreferLogStreaming=YESto the environment to silence warning.setupSimulators, saving some seconds in the CI.📚 Documentation
Removed some outdated screenshots related to the MockWebService integration.
✅ Testing
Removed outdated tests.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: