-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Single-Sign-On Provider #45
Support for Single-Sign-On Provider #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvement, happy to merge this as discussed in the meeting!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 82.49% 81.80% -0.69%
==========================================
Files 36 35 -1
Lines 988 978 -10
==========================================
- Hits 815 800 -15
- Misses 173 178 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Support for Single-Sign-On Provider
♻️ Current situation & Problem
Currently, we only support an E-Mail-Password-based authentication. SpeziAccount and SpeziFirebase just recently added support for Sign in with Apple. This PR incorporates those updated libraries.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
Similar to SpeziFirebase, we do not test Sign in with Apple in the Simulator directly as this cannot really be reliably achieved. Current test cases cover all the other changes made in this PR.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: