Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Single-Sign-On Provider #45

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 23, 2023

Support for Single-Sign-On Provider

♻️ Current situation & Problem

Currently, we only support an E-Mail-Password-based authentication. SpeziAccount and SpeziFirebase just recently added support for Sign in with Apple. This PR incorporates those updated libraries.

⚙️ Release Notes

  • Added support for Sign in with Apple

📚 Documentation

--

✅ Testing

Similar to SpeziFirebase, we do not test Sign in with Apple in the Simulator directly as this cannot really be reliably achieved. Current test cases cover all the other changes made in this PR.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg marked this pull request as ready for review October 23, 2023 16:55
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement, happy to merge this as discussed in the meeting!

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #45 (2971236) into main (cf19568) will decrease coverage by 0.69%.
The diff coverage is 96.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   82.49%   81.80%   -0.69%     
==========================================
  Files          36       35       -1     
  Lines         988      978      -10     
==========================================
- Hits          815      800      -15     
- Misses        173      178       +5     
Files Coverage Δ
...mplateApplication/Account/AccountSetupHeader.swift 100.00% <100.00%> (ø)
TemplateApplication/Account/AccountSheet.swift 84.91% <100.00%> (+3.09%) ⬆️
TemplateApplication/Home.swift 100.00% <100.00%> (ø)
...lateApplication/Onboarding/AccountOnboarding.swift 88.89% <100.00%> (-11.11%) ⬇️
TemplateApplication/TemplateApplication.swift 100.00% <100.00%> (ø)
...plateApplication/TemplateApplicationStandard.swift 51.64% <100.00%> (+0.40%) ⬆️
TemplateApplication/TemplateAppDelegate.swift 96.16% <80.00%> (-1.67%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf19568...2971236. Read the comment docs.

@Supereg Supereg merged commit 5796d90 into main Oct 23, 2023
6 checks passed
@Supereg Supereg deleted the feature/spezi-account-identity-provider-upgrade branch October 23, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants