-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new #Preview macro #44
Use the new #Preview macro #44
Conversation
adapt deployment target to iOS 17; adjust onChange modifiers because of depreciation
Just a very small update to take advantage of the new #Previews macro as I've been working on the TemplateApplication these days anyway. Also, #23 mentions that some views in the app crash or are non-existent. I found all previews working fine while updating to the macro, so I guess that information is outdated @PSchmiedmayer? I'm also thinking about a solution for StanfordSpezi/Spezi#63 atm. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 81.59% 82.58% +1.00%
==========================================
Files 35 35
Lines 999 987 -12
==========================================
Hits 815 815
+ Misses 184 172 -12
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in the review and thank you for the great additions and bringing #Preview
in the template app @NikolaiMadlener!
The PR looks good and is well structured, I only had a few smaller comments and suggestions for improvements across different files.
Let me know and feel free to re-request a review once you have resolved the different comments and/or if you have any questions 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the chances, this looks great! Thanks for all the work and effort that went into the PR @NikolaiMadlener! 🚀
Use the new #Preview macro
♻️ Current situation & Problem
As partially described in #23, currently all previews of views are written the old way using the
PreviewProvider
protocol.The new
#Preview
macro, introduced with iOS 17, should be used in every view instead.⚙️ Release Notes
📚 Documentation
✅ Testing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: