Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with macOS #39

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Compatibility with macOS #39

merged 7 commits into from
Mar 1, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Feb 29, 2024

Compatibility with macOS

♻️ Current situation & Problem

As of now, SpeziOnboarding does support the iOS and visionOS platforms, but not macOS natively.

⚙️ Release Notes

  • Add support for macOS
  • Consent Signature View is substituted with a text field

📚 Documentation

Added proper docs

✅ Testing

Ensure passing of test cases on macOS and all other existing platforms

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar self-assigned this Feb 29, 2024
@philippzagar philippzagar added the enhancement New feature or request label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 79.66805% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 76.75%. Comparing base (91463ae) to head (ed760be).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   78.31%   76.75%   -1.56%     
==========================================
  Files          21       22       +1     
  Lines        1028     1148     +120     
==========================================
+ Hits          805      881      +76     
- Misses        223      267      +44     
Files Coverage Δ
...ources/SpeziOnboarding/OnboardingConsentView.swift 91.20% <100.00%> (+1.78%) ⬆️
...ces/SpeziOnboarding/SequentialOnboardingView.swift 70.38% <100.00%> (+0.91%) ⬆️
...nboarding/ConsentView/ConsentDocument+Export.swift 98.06% <98.06%> (ø)
...rces/SpeziOnboarding/SignatureViewBackground.swift 86.49% <44.45%> (-13.51%) ⬇️
.../SpeziOnboarding/ConsentView/ConsentDocument.swift 80.99% <82.46%> (-8.01%) ⬇️
...ConsentView/OnboardingConsentView+ShareSheet.swift 56.25% <6.67%> (-43.75%) ⬇️
Sources/SpeziOnboarding/SignatureView.swift 68.50% <35.72%> (-20.63%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91463ae...ed760be. Read the comment docs.

@philippzagar philippzagar marked this pull request as ready for review February 29, 2024 23:04
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the tests and improvements; looks good to me!

@philippzagar philippzagar enabled auto-merge (squash) March 1, 2024 20:09
@philippzagar philippzagar merged commit 4971a82 into main Mar 1, 2024
18 checks passed
@philippzagar philippzagar deleted the feat/macos-support branch March 1, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants