-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mlx to version 2.21.2 #94
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 38.57% 38.34% -0.23%
==========================================
Files 64 64
Lines 2331 2345 +14
==========================================
Hits 899 899
- Misses 1432 1446 +14
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool; thank you for bumping this so quickly.
Happy to see it merged once all CI elements are passing and the existing warnings are addressed 🚀
Sorry @LeonNissen I was playing around with this branch and pushed a commit by mistake. I reverted it. Didn't mean to step on your toes. |
@vishnuravi No worries, feel free to play around with it, I am currently working on a different branch anyways 😊 |
Oh ok, cool, I will continue to work on this branch then. |
The Linkspector check is failing with a 403 when attempting to verify links to the OpenAI documentation that are valid and reachable from a regular web browser. This suggests that openAI is likely blocking GitHub IPs. I would make this check optional until these false positives are solved. |
That's unfortunate. |
The documentation for |
5bb77ce
to
629e4ab
Compare
@PSchmiedmayer addressed all your comments with a re-factor. Link check is also now passing. @LeonNissen and I tested on devices. Please take a look and we can merge if you have no other feedback. Thanks. |
Interesting that Apple just removed these entitlements.. @LeonNissen As you added these docs (I think), are they still beneficial in local SpeziLLM? If yes, is there an alternative? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for upgrading to the next major MLX version @LeonNissen and dealing with all the breaking changes! 🚀
Just had minor follow up questions.
Thank you for the review @philippzagar! Look forward to merging this and then getting the new DeepSeek models included via #97! |
13becbc
to
7a1e836
Compare
Rebased and fixed unsigned commits. |
Bumps mlx to version 2.21.2
♻️ Current situation & Problem
The MLX library is currently 1.18.1, and can be bumped to 2.x to support newer models.
⚙️ Release Notes
Updates the MLX library to 2.21.2 and migrates code for breaking changes.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: