Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mlx to version 2.21.2 #94

Merged
merged 17 commits into from
Feb 3, 2025
Merged

Bump mlx to version 2.21.2 #94

merged 17 commits into from
Feb 3, 2025

Conversation

LeonNissen
Copy link
Contributor

@LeonNissen LeonNissen commented Jan 27, 2025

Bumps mlx to version 2.21.2

♻️ Current situation & Problem

The MLX library is currently 1.18.1, and can be bumped to 2.x to support newer models.

⚙️ Release Notes

Updates the MLX library to 2.21.2 and migrates code for breaking changes.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@LeonNissen LeonNissen added the dependencies Pull requests that update a dependency file label Jan 27, 2025
@LeonNissen LeonNissen self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Project coverage is 38.34%. Comparing base (26b1e07) to head (7a1e836).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...urces/SpeziLLMLocal/LLMLocalSession+Generate.swift 0.00% 82 Missing ⚠️
Sources/SpeziLLMLocal/LLMLocalSession+Setup.swift 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   38.57%   38.34%   -0.23%     
==========================================
  Files          64       64              
  Lines        2331     2345      +14     
==========================================
  Hits          899      899              
- Misses       1432     1446      +14     
Files with missing lines Coverage Δ
Sources/SpeziLLMLocal/LLMLocalSchema.swift 0.00% <ø> (ø)
Sources/SpeziLLMLocal/LLMLocalSession.swift 0.00% <ø> (ø)
Sources/SpeziLLMLocal/LLMLocalSession+Setup.swift 0.00% <0.00%> (ø)
...urces/SpeziLLMLocal/LLMLocalSession+Generate.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b1e07...7a1e836. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool; thank you for bumping this so quickly.

Happy to see it merged once all CI elements are passing and the existing warnings are addressed 🚀

Package.swift Outdated Show resolved Hide resolved
@vishnuravi
Copy link
Member

vishnuravi commented Jan 28, 2025

Sorry @LeonNissen I was playing around with this branch and pushed a commit by mistake. I reverted it. Didn't mean to step on your toes.

@LeonNissen
Copy link
Contributor Author

LeonNissen commented Jan 28, 2025

Sorry @LeonNissen I was playing around with this branch and pushed a commit by mistake. I reverted it. Didn't mean to step on your toes.

@vishnuravi No worries, feel free to play around with it, I am currently working on a different branch anyways 😊

@vishnuravi
Copy link
Member

Sorry @LeonNissen I was playing around with this branch and pushed a commit by mistake. I reverted it. Didn't mean to step on your toes.

@vishnuravi No worries, feel free to play around with it, I am currently working on a different branch anyways 😊

Oh ok, cool, I will continue to work on this branch then.

@vishnuravi vishnuravi changed the title bump mlx to version 2.21.2 Bump mlx to version 2.21.2 Jan 28, 2025
@vishnuravi vishnuravi marked this pull request as ready for review January 28, 2025 23:12
@vishnuravi
Copy link
Member

The Linkspector check is failing with a 403 when attempting to verify links to the OpenAI documentation that are valid and reachable from a regular web browser. This suggests that openAI is likely blocking GitHub IPs. I would make this check optional until these false positives are solved.

@PSchmiedmayer
Copy link
Member

That's unfortunate.
@vishnuravi, what about adding a config file in the repo and adding the openai web page to the ignore pattern or just exclude the very specific link in the ignore pattern?

@vishnuravi
Copy link
Member

vishnuravi commented Feb 2, 2025

The documentation for Keychain Access Groups entitlement and Increase Memory Limit entitlement appear to be gone from the Apple website. Is this still relevant in the README? @philippzagar @LeonNissen

@vishnuravi
Copy link
Member

@PSchmiedmayer addressed all your comments with a re-factor. Link check is also now passing. @LeonNissen and I tested on devices. Please take a look and we can merge if you have no other feedback. Thanks.

@philippzagar
Copy link
Member

The documentation for Keychain Access Groups entitlement and Increase Memory Limit entitlement appear to be gone from the Apple website. Is this still relevant in the README? @philippzagar @LeonNissen

Interesting that Apple just removed these entitlements.. @LeonNissen As you added these docs (I think), are they still beneficial in local SpeziLLM? If yes, is there an alternative?

Copy link
Member

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for upgrading to the next major MLX version @LeonNissen and dealing with all the breaking changes! 🚀
Just had minor follow up questions.

Package.swift Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Tests/UITests/UITests.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Tests/UITests/UITests.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@vishnuravi
Copy link
Member

Thank you for upgrading to the next major MLX version @LeonNissen and dealing with all the breaking changes! 🚀 Just had minor follow up questions.

Thank you for the review @philippzagar! Look forward to merging this and then getting the new DeepSeek models included via #97!

@vishnuravi vishnuravi force-pushed the feature/bump-mlx-2.21.2 branch from 13becbc to 7a1e836 Compare February 3, 2025 14:06
@vishnuravi
Copy link
Member

Rebased and fixed unsigned commits.

@vishnuravi vishnuravi merged commit fe15019 into main Feb 3, 2025
19 of 20 checks passed
@vishnuravi vishnuravi deleted the feature/bump-mlx-2.21.2 branch February 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants