New Spezi Standard Implementation

[niallkehoe]

New Spezi Standard Implementation

♻️ Current situation & Problem

Currently, the SpeziHealthKit module lacks support for the new Spezi Standard released in Spezi 0.7.0
*This PR implements the improvements mentioned in [https://github.com/https://github.com/StanfordSpezi/Spezi/pull/73](Pull 73) *

💡 Proposed solution

Update the codebase to the newest Spezi 0.7.0

⚙️ Release Notes

This feature will allow for greater flexibility when using Spezi Questionnaire.

/// A Constraint which all `Standard` instances must conform to when using the Spezi HealthKit module.
public protocol QuestionnaireConstraint: Standard {
    /// Adds a new `HKSample` to the ``HealthKit`` module
    /// - Parameter response: The `HKSample` that should be added.
    func add(_ response: HKSample) async
    
    /// Removes a `HKSampleRemovalContext` from the ``HealthKit`` module
    /// - Parameter response: The `HKSampleRemovalContext` that contains information on the item that should be removed.
    func remove(removalContext: HKSampleRemovalContext)
}

Related PRs

See [https://github.com/https://github.com/StanfordSpezi/Spezi/pull/73](Pull 73) in Spezi for details

Testing

Passes all tests

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• [✅ ] I agree to follow the Code of Conduct and Contributing Guidelines.

[PSchmiedmayer]

@niallkehoe Thank you for the PR and the improvements to the HealthKit module! This really demonstrates how the new Standard implementation improves these types of interactions and how this leads to a cleaner UI for the Standards.

I had several comments across the PR, let me know if you have any questions or comments regarding the different elements! Happy to go into detail if you have any follow-up questions.

[codecov]

Codecov Report

Merging #9 (11cf6f5) into main (0a26f41) will increase coverage by 64.23%.
The diff coverage is 86.21%.

Additional details and impacted files

@@            Coverage Diff             @@
##            main       #9       +/-   ##
==========================================
+ Coverage   7.56%   71.79%   +64.23%     
==========================================
  Files         12       11        -1     
  Lines        463      436       -27     
==========================================
+ Hits          35      313      +278     
+ Misses       428      123      -305     

Files Changed	Coverage Δ
...althKit Extensions/HKHealthStore+SampleQuery.swift	0.00% <0.00%> (ø)
...Extensions/HKHealthStore+AnchoredObjectQuery.swift	85.19% <87.50%> (+85.19%)	⬆️
...hKit/CollectSample/HealthKitSampleDataSource.swift	96.33% <92.86%> (+96.33%)	⬆️
...s/SpeziHealthKit/CollectSample/CollectSample.swift	100.00% <100.00%> (+100.00%)	⬆️
.../SpeziHealthKit/CollectSample/CollectSamples.swift	100.00% <100.00%> (+70.59%)	⬆️
Sources/SpeziHealthKit/HealthKit.swift	88.41% <100.00%> (+50.38%)	⬆️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a26f41...11cf6f5. Read the comment docs.

[PSchmiedmayer]

@niallkehoe Thank you for continuing to work on the PR, let me know once you have addressed all comments and you think that it is in a good shape to give it an other review 🚀

[niallkehoe]

@paul Just uploaded my code after a check of all the files

[PSchmiedmayer]

Thank you for the improvements @niallkehoe! I only had a few very small comments that would be great to be addressed before we merge the PR. No need for an other review, you can merge the PR one the conversations are resolved.

Thank you for all the work and effort that went into improving Spezi and the HealthKit module!