-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional documents for CollectSample and HealthKitConstraint #18
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 69.90% 69.90%
=======================================
Files 11 11
Lines 455 455
=======================================
Hits 318 318
Misses 137 137
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @YurenSUN; this will help future students and Spezi users a lot!
I had a few suggestions there and there about smaller improvements, feel free to re-request a review once these are resolved 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YurenSUN Thank you for incorporating the improvements! I only had a small last comment; the PR already looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements and documentation additions! 🚀
Additional documents for CollectSample and HealthKitConstraint
♻️ Current situation & Problem
When working with this package for our PICS application, I found it a bit confusing about the
add
andremove
functions in theHealthKitConstraint
as I misunderstood them to be adding/removing health kit samples to/from the data sources instead of our application. Also, when usingCollectSample
, I spent some time finding how to filter the health kit query to collect data within the specific time range. I thought that this package did not support such filtering until I looked into the codes and realized that I could also input the predicate to it. I also found that the documentation mentioned the predicate initializations forCollectSample
only after I found the predicate parameter in the codes, and would appreciate that if it could be mentioned more clearly.I think adding more documentation and code examples for clarification will possibly not benefit those who are familiar with Swift documentation or HealthKit packages, but might help users who are new to Swift to get on board with this package more easily.
⚙️ Release Notes
📚 Documentation
Only additional documents were added were added in this PR.
✅ Testing
Only additional documents were added and no codes were changed. Also checked and verified the changes in the documentation by building documentation locally.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: