Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ID and Timestamp of ChatEntity configurable #12

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

philippzagar
Copy link
Member

Make ID and Timestampbof ChatEntity configurable

♻️ Current situation & Problem

As of now, the id and timestamp of the ChatEntity are not configurable and are just initialized at allocation.

⚙️ Release Notes

  • Make ID and Timestampbof ChatEntity configurable

📚 Documentation

Adjusted Docs

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Feb 22, 2024
@philippzagar philippzagar self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad4c88a) 84.14% compared to head (8786b96) 84.14%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files          13       13           
  Lines         580      580           
=======================================
  Hits          488      488           
  Misses         92       92           
Files Coverage Δ
Sources/SpeziChat/ChatView+SpeechButton.swift 100.00% <ø> (ø)
Sources/SpeziChat/Models/ChatEntity.swift 88.89% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4c88a...8786b96. Read the comment docs.

@philippzagar philippzagar requested a review from Supereg February 23, 2024 00:38
Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

@philippzagar philippzagar merged commit eae5c15 into main Feb 23, 2024
9 checks passed
@philippzagar philippzagar deleted the feat/make-id-configurable branch February 23, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants