Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountOverviewForm: take closeBehavior into account #80

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

lukaskollmer
Copy link
Member

AccountOverviewForm: take closeBehavior into account

♻️ Current situation & Problem

AccountOverview allows specifying a closeBehavior value, which is documented as controlling whether a "Close" button is shown as part of the view.
However, this value is currently ignored, and the close button is always shown.

⚙️ Release Notes

  • AccountOverview: fix closeBehavior not having any effect

📚 Documentation

n/a

✅ Testing

n/a

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@lukaskollmer lukaskollmer requested a review from Supereg December 9, 2024 20:16
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.83%. Comparing base (37df11e) to head (3a84cfd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nt/Views/AccountOverview/AccountOverviewForm.swift 90.91% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   83.95%   83.83%   -0.11%     
==========================================
  Files         121      121              
  Lines        5251     5256       +5     
==========================================
- Hits         4408     4406       -2     
- Misses        843      850       +7     
Files with missing lines Coverage Δ
...nt/Views/AccountOverview/AccountOverviewForm.swift 88.76% <90.91%> (-0.26%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37df11e...3a84cfd. Read the comment docs.

@PSchmiedmayer
Copy link
Member

Looks good; thank you @lukaskollmer! 🚀

@lukaskollmer lukaskollmer merged commit 273bd00 into main Dec 9, 2024
11 checks passed
@lukaskollmer lukaskollmer deleted the lukas/account-form-fix branch December 9, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants