Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject security related modifier in single edit view #56

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Apr 4, 2024

Inject security related modifier in single edit view

♻️ Current situation & Problem

This PR addresses an issue where the securityRelatedViewModifier of an account service was not injected into the single row edit view.

⚙️ Release Notes

  • Inject security related modifier in single edit view

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer April 4, 2024 04:46
@Supereg Supereg marked this pull request as ready for review April 4, 2024 04:46
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; only had one clarifying comment in the diff. Thank you @Supereg!

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 76.18%. Comparing base (76b69a9) to head (688e900).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   76.33%   76.18%   -0.14%     
==========================================
  Files         116      116              
  Lines        4012     4017       +5     
==========================================
- Hits         3062     3060       -2     
- Misses        950      957       +7     
Files Coverage Δ
...SpeziAccount/AccountValue/AccountKeyCategory.swift 80.00% <ø> (ø)
...ziAccount/Views/AccountOverview/NameOverview.swift 69.85% <100.00%> (ø)
Sources/SpeziAccount/Account.swift 77.20% <25.00%> (-2.45%) ⬇️
...Views/AccountSetup/DefaultAccountSetupHeader.swift 64.52% <0.00%> (-9.55%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b69a9...688e900. Read the comment docs.

@Supereg Supereg merged commit cb9441e into main Apr 4, 2024
7 of 8 checks passed
@Supereg Supereg deleted the fix/modifier-edit-view branch April 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants