generated from StanfordBDHG/SwiftPackageTemplate
-
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
AccountSetup
view ignoring all identity providers per section b…
…ut one (#81) # Fix `AccountSetup` view ignoring all identity providers per section but one ## ♻️ Current situation & Problem Currently, the AccountSetupView groups the AccountService's `IdentityProvider`s by their section, to determine their order. As a result of this being implemented using a dictionary, with the providers as values, only the last provider per section is kept. This means that, if an AccountService specifies multiple IdentityProviders for a section, most of them (all but one) will not be shown to the user. ## ⚙️ Release Notes - Fixed `@IdentityProvider`s sometimes not being included in the `AccountSetup` view. ## 📚 Documentation n/a ## ✅ Testing n/a ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
- Loading branch information
1 parent
de42790
commit 41aed07
Showing
8 changed files
with
12 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+68 Bytes
(100%)
...hots__/SnapshotTesting/testAccountProviderViewLayoutVariations.iphone-view0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+79 Bytes
(100%)
...hots__/SnapshotTesting/testAccountProviderViewLayoutVariations.iphone-view1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+277 Bytes
(100%)
...SnapshotTesting/testAccountProviderViewLayoutVariations.iphone-view2-signup.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+277 Bytes
(100%)
...hots__/SnapshotTesting/testAccountProviderViewLayoutVariations.iphone-view2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+255 Bytes
(100%)
...SnapshotTesting/testAccountProviderViewLayoutVariations.iphone-view4-signup.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+255 Bytes
(100%)
...hots__/SnapshotTesting/testAccountProviderViewLayoutVariations.iphone-view4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.