Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor concurrency adjustments #114

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 15, 2024

Minor concurrency adjustments

♻️ Current situation & Problem

With Xcode Beta 5 there are new region-based concurrency checks that trigger a warning about strongly transferred parameters (see SE-0414) when passing actor isolated closures that is not explicitly marked as @Sendable.
This PR resolves those warning by adding an explicit @Sendable annotation.

Interestingly the Swift Package Index marks Spezi 1.7.1 to be Swift 6 compatible even though they compile the project with Beta 5.

⚙️ Release Notes

  • Minor concurrency adjustments.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer August 15, 2024 09:20
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.33%. Comparing base (87d735b) to head (24440fc).
Report is 1 commits behind head on main.

Files Patch % Lines
.../Spezi/Spezi/SpeziNotificationCenterDelegate.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          47       47           
  Lines        1602     1602           
=======================================
  Hits         1447     1447           
  Misses        155      155           
Files Coverage Δ
Sources/Spezi/Spezi/SpeziAppDelegate.swift 91.16% <100.00%> (ø)
.../Spezi/Spezi/SpeziNotificationCenterDelegate.swift 5.98% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d735b...24440fc. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg!

@Supereg Supereg merged commit 7755013 into main Aug 15, 2024
15 of 16 checks passed
@Supereg Supereg deleted the fix/xcode16-beta5-concurrency branch August 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants