-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biostrap/EVO Full Suite #135
Conversation
tests/devices/biostrap/test_evo.py
Outdated
- datetime.strptime(date_1, "%Y-%m-%d") | ||
).days == 1, f"Dates are not consecutive: {date_1}, {date_2}" | ||
|
||
assert dates[0] == start_synthetic.strftime( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the following test cases, make the assertion messages more descriptive (i.e. First date is not equal to start date)
webbrowser.open(authorization_url) | ||
|
||
# Get the authorization response URL from the command line: is there a better way to do this? | ||
authorization_response = input("Enter the full callback URL: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to do request.get(auth_url)? That should return the redirect url equivalent to putting the authorization url into the search bar. let me know if this can work, otherwise let's call and talk about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the method you mentioned, but it doesn't seem to work at the moment.
Merging latest changes from upstream/main to keep my branch up to date with the original repository.
…ported by Biostrap (formatted by pre-commit hooks)
TZ_OFFSET = -420 | ||
|
||
# Helper functions for biometric data generation | ||
def synthetic_biometrics(start_date_obj, end_date_obj): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like here your high frequency data is uniformly random. I think a good improvement here would be to use a more complex generator to make it look more realistic. Some example generators exist in Garmin Fenix 7s, Polar Verity Sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the data is still pretty noisy, could you try another generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need you to change the generator and also make sure the tests run. Otherwise, looking good!
TZ_OFFSET = -420 | ||
|
||
# Helper functions for biometric data generation | ||
def synthetic_biometrics(start_date_obj, end_date_obj): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the data is still pretty noisy, could you try another generator?
…m and hrv metrics and only adds confusion
} | ||
|
||
def synthetic_sleep_session(bpm_dict): | ||
print(f"This is the {bpm_dict}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this print statement is necessary
This reverts commit f3c69a2.
Description
I have made a preliminary PR of the entire Wearipedia extraction and testing API.
Related Issue