Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios and urijs package version updated #854

Merged

Conversation

shital-orchestral
Copy link
Contributor

Axios package version updated to 0.21.1 and urijs to 1.19.4.
Thanks

@blag blag added this to the 3.4.0 milestone Feb 2, 2021
@blag
Copy link
Contributor

blag commented Feb 2, 2021

@shital-orchestral Thank you for the contribution, but this breaks tests. Can you fix those?

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Thanks @shital-orchestral for the fix 👍

Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@m4dcoder m4dcoder merged commit 78166dd into StackStorm:master Feb 11, 2021
@arm4b
Copy link
Member

arm4b commented Feb 11, 2021

@shital-orchestral @m4dcoder Looks like yarn.lock still includes old versions here:
https://github.com/StackStorm/st2web/blob/master/yarn.lock

Can you elaborate if it still needs an update and how that plays out in the build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants