Change License for OpenSource

[arm4b]

Currently the license file in repo and packages lists Extreme Workflow Composer EULA, including Homepage: https://www.extremenetworks.com/product/workflow-composer/ and other Extreme Networks references. This applies to repository descriptions and READMEs.

This should be changed to Apache 2 OSS license by someone from Extreme that open-sourced it.
Same for the Copyright record in every file which doesn't list Apache 2 license, example: https://github.com/StackStorm/st2flow/blob/master/modules/st2-login/login.component.js

[mickmcgrath13]

I recommend we archive this repo and make these license changes in this PR:
StackStorm/st2web#759 (comment)

[arm4b]

Why not both? :)
This way someone browsing or forking st2flow repository (even archived) has opportunity to modify and re-use it openly and we won't have repos with the proprietary license in StackStorm org as well.
I guess also that st2flow repository comes first as Extreme advertised its opensourcing, but we still have closed source license here.

[mickmcgrath13]

My main hesitation in doing both is code duplicity and the risk of their getting out of sync.

If we want both repos, we should really split out the common components into a separate repo (like st2flow-components or similar) and have both st2web and st2flow use them.

The alternative to have st2flow integrated into st2web is to have a "parent" repo that pulls in st2flow and st2web.

So, to recap, options (in order of preference from greatest to least):

1) Deprecate st2flow

Copy relevant components form st2flow directly into st2web and maintain them there (deprecating st2flow).

That's this: StackStorm/st2web#759

I prefer this method if we can (partly because it's mostly done already).

2) Separate component libarary

To avoid risk of code duplicity and out-of-sync-ness, we should create st2flow-components with the common elements (StackStorm/st2web#759 should give some insight into what needs to go there), and then update st2web and st2flow to pull their components from st2flow-components.

An added benefit of this would be that folks can use the components to build their own ui pieces for a drag and drop stackstorm editor (like a VSCode plugin or a Electron wrapped desktop app, for example).

3) Parent repo

Create a parent repo which pulls in both st2web and st2flow and merges them together somehow to create an ST2 UI that has the drag and drop editor.
I believe EN was doing something like this.

4) Duplication

Duplicate code for the drag and drop editor in both st2flow and st2web and risk their getting out of sync

[arm4b]

Yeah, I agree with you that st2flow archival and moving the code into st2web is the best option that may simplify operations, management and even migration 👍

However before re-using st2flow code, original (this) repo should have the OSS license first. Same problem here StackStorm/st2-rbac-backend#32 (comment)

[mickmcgrath13]

gotcha, so:

1. Resolve this issue
2. do the same for Integrate st2flow st2web#759
3. merge Integrate st2flow st2web#759
4. deprecate st2flow
5. explore the future (like st2flow-components for example)

..something like that?

[mickmcgrath13]

@armab @m4dcoder

What do we want the licenses to be?

The easiest path is to replicate what st2web is doing:

license

https://github.com/StackStorm/st2web/blob/master/LICENSE

Readme

https://github.com/StackStorm/st2web/blob/master/README.md#copyright-license-and-contributors-agreement

js files

https://github.com/StackStorm/st2web/blob/master/modules/st2-action-reporter/action-reporter.component.js#L1
still has

Copyright 2019 Extreme Networks, Inc.

but also has apache license, version 2.0 stuff

css files

no analogy in st2web that I could see. would do:

/*
Copyright 2019 Extreme Networks, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

[arm4b]

For st2flow license transition from closed-source proprietary to open-source Apache 2.0.

Existing st2web https://github.com/StackStorm/st2web/blob/master/modules/st2-action-reporter/action-reporter.component.js#L1
+
Existing st2flow https://github.com/StackStorm/st2flow/blob/master/modules/st2-style/colors.css#L2

The resulting Apache 2.0 header will look the following:

// Copyright 2020 Extreme Networks, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Note the updated year in copyright header for st2flow. That needs to be preserved.

And yes, Apache 2.0 LICENSE file is the same across the repositories.