Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated node #161

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Updated node #161

merged 6 commits into from
Jun 7, 2021

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented May 6, 2021

Testing the build as part of investigating nodejs upgrade

@amanda11 amanda11 marked this pull request as draft May 6, 2021 22:50
@arm4b
Copy link
Member

arm4b commented May 9, 2021

Node version requirements are defined in the deb/rpm package specs:

Requires: nodejs >= 2:8.0, nodejs < 2:11.0

Depends: nodejs (>= 8.0.0), nodejs (<< 11.0.0)

Next, package.json

st2chatops/package.json

Lines 27 to 29 in dc4bd38

"engines": {
"node": ">=8.0 <11.0"
}

And good news, looks like in hubot-stackstorm which is a core component of st2 chatops solution,
looks like we already test with nodejs 12: https://github.com/StackStorm/hubot-stackstorm/blob/48eccfdbcbc5e3f72d2dbe8c366bd5648207ef50/.travis.yml#L10 (https://travis-ci.org/github/StackStorm/hubot-stackstorm/builds/548411849)

Hopefully @blag could help with the pointers more.

@amanda11 amanda11 changed the title WIP Test build WIP Updated node and hubot-stackstorm dependencies May 17, 2021
@amanda11 amanda11 added this to the 3.5.0 milestone May 17, 2021
@amanda11
Copy link
Contributor Author

Build passed. Not yet tried the package in a node > 10 environment.

@amanda11 amanda11 marked this pull request as ready for review May 20, 2021 21:58
@amanda11 amanda11 changed the title WIP Updated node and hubot-stackstorm dependencies Updated node and hubot-stackstorm dependencies May 20, 2021
@amanda11 amanda11 changed the title Updated node and hubot-stackstorm dependencies WIP Updated node and hubot-stackstorm dependencies May 20, 2021
@amanda11 amanda11 marked this pull request as draft May 20, 2021 22:09
@amanda11
Copy link
Contributor Author

When built against node 10, and installed on a ST2 using node 14 and connected to slack - ran initial tests ok.
When built against node 14 (As per last commit) and installed on ST2 using node 14, got authorisation issues connecting to slack. Not been able to track down why.

@amanda11 amanda11 changed the title WIP Updated node and hubot-stackstorm dependencies WIP Updated node Jun 3, 2021
@amanda11 amanda11 changed the title WIP Updated node Updated node Jun 4, 2021
@amanda11 amanda11 marked this pull request as ready for review June 4, 2021 15:05
@amanda11
Copy link
Contributor Author

amanda11 commented Jun 4, 2021

Merged latest changes in, and re-built dependencies.
Manual isntall of ST2 on EL8 with node 14. Put in place artifact from this build and tested against live slack - all ok.

@amanda11 amanda11 mentioned this pull request Jun 4, 2021
8 tasks
@amanda11 amanda11 requested review from blag and arm4b June 6, 2021 16:57
@amanda11 amanda11 merged commit ed73f0d into master Jun 7, 2021
@amanda11 amanda11 deleted the test_build branch June 7, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants