Add TODO for improving the vagrant_tag_release action #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release process tweaks the changelog for the StackStorm/packer-st2 project and creates and pushes a new tag to match the StackStorm version.
When the changelog changes are pushed, a CircleCI build is started. However, the
vagrant_tag_releaseaction never checks for the status of the CircleCI build. If the CircleCI build fails, a Vagrant image will not actually be created for that StackStorm release. That means that the release manager will need to make a PR to the packer-st2, and merge changes, but the new tag won't ever be updated to point to the fixed commit.The script is smart enough to skip updating the changelog if it already contains the version blurb, but the script will simply bail out if the tag already exists.
Instead the script should update the tag to point to the latest commit. It might be prudent to hide this behavior behind a
forceparameter or something like that.This PR adds a TODO message to do exactly that. This might be a good task for a community member to get familiar with this repo.