-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tell pants about tests that use globs to test with many pack fixtures #5874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am worried that we are going to forget to do this when we add a new test pack.
I am just wondering if we can either discover these or if we need to have a comment in the current test packs that exist that they are registered here. So that if someone copies an existing pack they will see the message that they also have to add here.
Yes. I agree. I already stumbled over that when packs were added after I added this (in my PoC branch awhile ago). So, I want a better solution than just comments. Dependencies are not allowed to use globs because things like But, I can probably add a new pants plugin, or perhaps extend the Yeah. I'll add it to |
99493a2
to
fcc2302
Compare
Pull request was converted to draft
e73fd3f
to
0efe93d
Compare
Upon closer inspection, I realized I don't understand the one test that would use the Also, I updated |
3aac033
to
1b082cd
Compare
This is ready for review now. |
packs_glob( | ||
name="all_packs", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing depends on this (and the one in packs_invalid) directly right now. We will need both to include all the packs in the wheel.
d6653b0
to
e159a1c
Compare
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This PR:
packs_glob
target (inpants-plugins/pack_metadata
) with a rule that "infers" dependencies (like a*
glob) on all of the subdirectories (unless ignored in thedependencies
field).st2tests/st2tests/fixtures/packs/all_packs_glob
for tests that use globs to discover a bunch of packs. This fixture depends on thepacks_glob(name="all_packs")
target to facilitate the glob behavior.This PR is basically a follow-up to the "Use python imports to identify fixtures" PRs: #5699, #5702, #5703, #5704, #5705, and #5706. But, instead of including these fixtures in that series of PRs, I waited to add this until after the
pack_metadata
targets were added in #5871.