Replace ubuntu focal with jammy #70
Conversation
- Update Dockerfiles for ubuntu jammy for base/ , st2chatops/ and st2web/ components - Correct staging package source - Update nodesource setup version in st2chatops, compatible with jammy
|
|
|
Will this change the OS for container build for St2 v3.8? |
Hello @nzlosh , I have not much idea on how the release process of containers are running but i think there should be a tag mechanism for the release which obviously should depend on the ST2 version being used as ARG - https://github.com/StackStorm/st2-dockerfiles/blob/cebea8dd374fbca30b1974b7c33e8adfd99116e8/base/Dockerfile#L5C5-L5C16 , what do you think ? Also if you notice the new images get the tag - https://app.circleci.com/pipelines/github/StackStorm/st2-dockerfiles/1994/workflows/164f38f9-72e4-4db9-a64b-1448e96d0b5f/jobs/2527 REPOSITORY TAG IMAGE ID CREATED SIZE
stackstorm/st2web 3.9dev 9ea43a83b34d 1 second ago 185MB
stackstorm/st2chatops 3.9dev 2e0c58128ee8 32 seconds ago 494MB
stackstorm/st2actionrunner 3.9dev 9948c9ac76a2 About a minute ago 588MB
stackstorm/st2notifier 3.9dev 099eae53bfad 2 minutes ago 577MB
stackstorm/st2scheduler 3.9dev 5d6447776843 2 minutes ago 577MB
stackstorm/st2sensorcontainer 3.9dev a4177311ec80 2 minutes ago 577MB
stackstorm/st2stream 3.9dev fce18673b761 2 minutes ago 577MB
stackstorm/st2 3.9dev 6f2524b671dc 2 minutes ago 577MB
stackstorm/st2timersengine 3.9dev aa3a3c8629f8 2 minutes ago 577MB
stackstorm/st2auth 3.9dev 1972faa7fbd2 2 minutes ago 577MB
stackstorm/st2rulesengine 3.9dev 98e8d376a260 2 minutes ago 577MB
stackstorm/st2api 3.9dev fb865cb3371b 2 minutes ago 577MB
stackstorm/st2workflowengine 3.9dev 4475e9cfcb17 2 minutes ago 577MB
stackstorm/st2garbagecollector 3.9dev c4fd51efe30b 2 minutes ago 577MB
public.ecr.aws/eks-distro/kubernetes/pause 3.6 3c69a9ca2c95 15 months ago 6.62MB
docker 18-git 796b9c4f0b4e 5 years ago 213MBI dont see the v3.8 images being created every night here - https://app.circleci.com/pipelines/github/StackStorm/st2-dockerfiles . So how are they uploaded ? This change once merged, will mean that any new image build on master will have new OS yes but if the v3.8 images (prod) are not built with ever new merge to master, then it should be safe. Please let me know. |
|
The reason I asked is because v3.8 is still the current release. If we need to produce a security release for it (unlikely but possible), v3.8 is not supported on Jammy and this change would cause build failures. To handle this case now and in the future there needs to be some sort of logic put in place that can select the correct base image given the tag being built. This could be a map in the makefile that updates a dockerfile template at build time for example. |
|
Yes i understand, but do you want to incorporate that feature with this request ? or you plan to discuss the Makefile request with TSC members first ? |
|
Implementing the fix now will be fine. If there needs to be adjustments made in the future it can be handled in another issue. |
|
But I have no idea on previous tags - base images. I mean what could be the mapping for earlier tagged release then ? Suppose we put 3.8.* as ubuntu:focal and 3.9.* as ubuntu:jammy, what about the previous tags ? |
|
The currently supported version of st2 is v3.8 and will become unsupported when v3.9 is released. Your suggestion of handling these two versions is reasonable. Once v3.9 is released, we can update the mapping to define v3.9 and v3.10 base images. |
Replace ubuntu focal with jammy
Update Dockerfiles for ubuntu jammy for base/ , st2chatops/ and st2web/ components
Correct staging package source
Update nodesource setup version in st2chatops, compatible with jammy