RabbitMQ and Metrics #358

bishopbm1 · 2022-05-20T21:40:32Z

Added Metrics configuration options to to setup and configure metrics endpoint needed for metrics collection. Will be using this and adding documentation on setting up Prometheus.

RabbitMQ and erlang changes the repository styles so added some configuration options so if they change again we can more easily update. PackageCloud documentation:
https://packagecloud.io/rabbitmq/erlang/install#bash-rpm
https://packagecloud.io/install/repositories/rabbitmq/erlang/config_file.repo?os=rhel&dist=8&source=script

Relies on the folllowing PR for additional fixes:
voxpupuli/puppet-rabbitmq#907
While waiting for that to be merged this repo and branch can be used:
https://github.com/EncoreTechnologies/puppet-rabbitmq/tree/feature/fix-yum-repo
This repo and branch will remain until the PR is merged.

Error:

Error: Execution of '/usr/bin/dnf -d 0 -e 1 -y install rabbitmq-server' returned 1: Importing GPG key 0x4D206F89:
 Userid     : "https://packagecloud.io/rabbitmq/rabbitmq-server (https://packagecloud.io/docs#gpg_signing) <support@packagecloud.io>"
 Fingerprint: 8C69 5B02 19AF DEB0 4A05 8ED8 F4E7 8920 4D20 6F89
 From       : https://packagecloud.io/rabbitmq/rabbitmq-server/gpgkey
Error: Failed to download metadata for repo 'rabbitmq_erlang': repomd.xml GPG signature verification error: Bad GPG signature
Error: /Stage[main]/Rabbitmq::Install/Package[rabbitmq-server]/ensure: change from 'purged' to 'present' failed: Execution of '/usr/bin/dnf -d 0 -e 1 -y install rabbitmq-server' returned 1: Importing GPG key 0x4D206F89:
 Userid     : "https://packagecloud.io/rabbitmq/rabbitmq-server (https://packagecloud.io/docs#gpg_signing) <support@packagecloud.io>"
 Fingerprint: 8C69 5B02 19AF DEB0 4A05 8ED8 F4E7 8920 4D20 6F89
 From       : https://packagecloud.io/rabbitmq/rabbitmq-server/gpgkey
Error: Failed to download metadata for repo 'rabbitmq_erlang': repomd.xml GPG signature verification error: Bad GPG signature

merge latest

merge master

Added params for metrics section in config file

…o feature/update-master

Feature/update master

…nd incorrect tests. Updated tests to support new python version. Fixed all failing builds

CLAassistant · 2022-05-20T21:40:41Z

All committers have signed the CLA.

…updates

arm4b

Huge work here! 👍
Thanks a lot for the PR + fix.

It would be ideal to split the fix vs feature in separated PRs for better history, separation of concern, diff, and review.

I left a few comments, but up to @rush-skills to review & approve as Puppet is not my primary thing.

build/centos7-puppet6/Puppetfile

manifests/params.pp

rush-skills

LGTM now, except failing tests

rush-skills · 2022-05-23T08:55:35Z

spec/classes/profile/web_spec.rb

@@ -149,6 +149,34 @@
                  },
                  tag: ['st2', 'st2::backend', 'st2::backend::api'])
        end
+        it do
+          is_expected.to contain_nginx__resource__location('@basic_statusError')


Should these tests only run when the basic status page is enabled?

Yea working on fixing the tests. I have a pretty busy day today though so it might have to wait till tomorrow.

rush-skills · 2022-05-23T16:48:03Z

Thanks for fixing the tests - all looks green now after so long!
One question though, sorry for my lack of knowledge - what is the Nginx basis status supposed to proxy? Is it a health check service of st2, nginx or something custom?

arm4b · 2022-05-24T09:54:02Z

build/centos7-puppet6/Puppetfile

+# Waiting on https://github.com/voxpupuli/puppet-rabbitmq/pull/907 to be
+# merged into upstream repo.
+mod 'puppet/rabbitmq',
+    :git => 'https://github.com/EncoreTechnologies/puppet-rabbitmq.git',
+    :branch => 'feature/fix-yum-repo',
+    :default_branch => 'master'


As voxpupuli/puppet-rabbitmq#907 was merged,
looks like we can rely on the official version now 👍

build/centos7-puppet6/Puppetfile

bishopbm1 · 2022-06-07T14:31:50Z

@armab can you re-run tests. They all succeeded in my repo

arm4b · 2022-06-07T15:09:36Z

@bishopbm1 Sure, let's see. Thanks for bumping this!

@rush-skills Is there anything else left addressing in this PR to move forward?

rush-skills

LGTM now if tests pass

rush-skills · 2022-06-07T15:11:58Z

@bishopbm1 Can you also describe/document on the metrics and nginx_basic_status parts that you have added in here? Would love to try them out in my setup

bishopbm1 · 2022-06-07T15:14:17Z

@bishopbm1 Can you also describe/document on the metrics and nginx_basic_status parts that you have added in here? Would love to try them out in my setup

Yea i'll throw something quick in the readme

rush-skills · 2022-06-07T15:48:58Z

@bishopbm1 CI is all green again 🥳
I can go ahead with the merge, or wait for the README changes

… Also updated other pieces of documentation for python 3.8

bishopbm1 · 2022-06-07T16:40:17Z

@rush-skills I added a simple description. I plan to build this out a lot more in coming month but that is definitely its own PR. If you message me in the ST2 channel I can help you with how we are scraping the data to get it to prometheus.

rush-skills · 2022-06-07T16:42:27Z

@bishopbm1 Thanks, that helps keep the module docs still complete for that profile. I will merge this once CI passes.

bishopbm1 and others added 21 commits August 31, 2021 16:16

Merge pull request #9 from StackStorm/master

bf07478

merge latest

Merge pull request #11 from StackStorm/master

218b168

merge master

Added params for metrics section in config file

0f3b898

Adding route to /basic_status to get stub_status metrics from nginx

233e8df

removing extra spaces

d497ab6

Adding resource location for nginx stub status module

92f4804

syntax fixes

0819c46

removing index.html from index_files

1ee4a47

removing more copy/paste errors (www_root)

f76a11d

adding nginx basic_status port to init. updating CHANGELOG and metadata

ce5fdc6

Fixing syntax

f145814

Fixing input

b862bd2

Fixing type

062831b

Fixing tests

1948db6

Merge pull request #12 from EncoreTechnologies/feature/metric-conf

3481e6e

Added params for metrics section in config file

Merge branch 'master' of https://github.com/StackStorm/puppet-st2 int…

2f1207a

…o feature/update-master

Merge pull request #14 from EncoreTechnologies/feature/update-master

c13ef3a

Feature/update master

Added metrics to its own file. Fixed RabbitMQ errors. Fixed failing a…

7b7b055

…nd incorrect tests. Updated tests to support new python version. Fixed all failing builds

Pinning erlang to the 24 for rhel 8

9d05525

Removed fix and RabbitMQ pushed a new package.

2083d40

Added metrics to its own file. Fixed RabbitMQ errors. Fixed failing a…

dc775f6

…nd incorrect tests. Updated tests to support new python version. Fixed all failing builds

Merge https://github.com/StackStorm/puppet-st2 into feature/rabbitmq-…

d757e56

…updates

bishopbm1 requested a review from rush-skills May 20, 2022 21:50

arm4b reviewed May 21, 2022

View reviewed changes

build/centos7-puppet6/Puppetfile Outdated Show resolved Hide resolved

build/centos7-puppet6/Puppetfile Outdated Show resolved Hide resolved

manifests/params.pp Show resolved Hide resolved

Adding comments to code and and override for the basic status report.

3bb372f

rush-skills approved these changes May 23, 2022

View reviewed changes

rush-skills self-requested a review May 23, 2022 08:53

rush-skills reviewed May 23, 2022

View reviewed changes

Merge branch 'feature/rabbitmq-updates' into hotfix/testing-updates

9e199d7

bishopbm1 added 6 commits May 23, 2022 09:28

attempting to fix tests.

43e04e7

Fixing tests.

906cbcb

Fixing syntax issue.

56878e8

Removing params.

0d1cd03

Down to only 8 failing tests.

0434c62

moving basic status to its own test since not enabled by default.

3d2defb

arm4b reviewed May 24, 2022

View reviewed changes

rush-skills requested changes May 24, 2022

View reviewed changes

build/centos7-puppet6/Puppetfile Show resolved Hide resolved

Switching builds to upstream.

9415cc2

rush-skills approved these changes Jun 7, 2022

View reviewed changes

Updated readme with new metrics parameters and how those can be used.…

0a4faf2

… Also updated other pieces of documentation for python 3.8

rush-skills merged commit 1a1d045 into StackStorm:master Jun 7, 2022

rush-skills mentioned this pull request Jul 6, 2022

TSC Meeting (12 Jul 2022): pants, Puppet-ST2 metrics, CI/CD and AWS discussions, v3.8 release planning StackStorm/community#105

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RabbitMQ and Metrics #358

RabbitMQ and Metrics #358

bishopbm1 commented May 20, 2022

CLAassistant commented May 20, 2022 •

edited

Loading

arm4b left a comment

rush-skills left a comment •

edited

Loading

rush-skills May 23, 2022

bishopbm1 May 23, 2022

rush-skills commented May 23, 2022

arm4b May 24, 2022

bishopbm1 commented Jun 7, 2022

arm4b commented Jun 7, 2022 •

edited

Loading

rush-skills left a comment

rush-skills commented Jun 7, 2022

bishopbm1 commented Jun 7, 2022

rush-skills commented Jun 7, 2022

bishopbm1 commented Jun 7, 2022

rush-skills commented Jun 7, 2022

RabbitMQ and Metrics #358

RabbitMQ and Metrics #358

Conversation

bishopbm1 commented May 20, 2022

CLAassistant commented May 20, 2022 • edited Loading

arm4b left a comment

Choose a reason for hiding this comment

rush-skills left a comment • edited Loading

Choose a reason for hiding this comment

rush-skills May 23, 2022

Choose a reason for hiding this comment

bishopbm1 May 23, 2022

Choose a reason for hiding this comment

rush-skills commented May 23, 2022

arm4b May 24, 2022

Choose a reason for hiding this comment

bishopbm1 commented Jun 7, 2022

arm4b commented Jun 7, 2022 • edited Loading

rush-skills left a comment

Choose a reason for hiding this comment

rush-skills commented Jun 7, 2022

bishopbm1 commented Jun 7, 2022

rush-skills commented Jun 7, 2022

bishopbm1 commented Jun 7, 2022

rush-skills commented Jun 7, 2022

CLAassistant commented May 20, 2022 •

edited

Loading

rush-skills left a comment •

edited

Loading

arm4b commented Jun 7, 2022 •

edited

Loading