Skip to content

Commit

Permalink
Fix codeowners file
Browse files Browse the repository at this point in the history
Earlier cephci-top-reviewers had open permissions to merge code
to any place. The teams mentioned for folders had no impact. This
caused improper delegation of ownership.

This change removes the top-reviewers group and sets the complete
privileges to ceph-qe-ci and ceph-qe-admin groups. They have full
access to merge.

The delegation to each DFG is now done via specfic users with their
managers having permissions to merge in their respective components.

Going forward, anyone should be able to raise a PR to request for
merge permissions with admin and ci teams having approval privileges.

Signed-off-by: Pragadeeswaran Sathyanarayanan <pragadeeswaran.sathyanarayanan@ibm.com>
  • Loading branch information
psathyan committed Jan 2, 2025
1 parent 19d526a commit d640368
Showing 1 changed file with 17 additions and 12 deletions.
29 changes: 17 additions & 12 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,24 +1,29 @@
# These owners will be the default owners for everything in this repo.
# all changes.
* @red-hat-storage/cephci-top-reviewers
* @red-hat-storage/ceph-qe-ci @red-hat-storage/ceph-qe-admin

# for RGW
rgw/ @red-hat-storage/teams/cephci-rgw
rgw/ @mkasturi18 @ckulal @TejasC88

# for RBD team
rbd/ @red-hat-storage/teams/cephci-block
rbd_mirror/ @red-hat-storage/teams/cephci-block
rbd/ @Manohar-Murthy
rbd_mirror/ @Manohar-Murthy

# for NVMe-oF
nvmeof/ @Manohar-Murthy @HaruChebrolu

# for RADOS
rados/ @ed-hat-storage/teams/cephci-rados
rados/ @neha-gangadhar @pdhiran

# for FS
cephfs/ @red-hat-storage/teams/cephci-fs
cephfs/ @neha-gangadhar @AmarnatReddy @Manimaran-MM

# smb
smb/ @vdas-redhat @pranavprakash20

# for DMFG
ansible/ @red-hat-storage/teams/cephci-dm
upgrades/ @red-hat-storage/teams/cephci-dm
dashboard/ @red-hat-storage/teams/cephci-dm
cephadm/ @red-hat-storage/teams/cephci-dm
ceph_ansisble/ @red-hat-storage/teams/cephci-dm
ceph_installer/ @red-hat-storage/teams/cephci-dm
ceph_volume/ @vdas-redhat @pranavprakash20
cephadm/ @vdas-redhat @pranavprakash20
mgr/ @vdas-redhat @pranavprakash20
nfs/ @vdas-redhat @pranavprakash20
upgrades/ @vdas-redhat @pranavprakash20

0 comments on commit d640368

Please sign in to comment.