Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approved field to Event model #117

Merged
merged 12 commits into from
Aug 24, 2024
Merged

Conversation

joeriddles
Copy link
Contributor

@joeriddles joeriddles commented Aug 15, 2024

Pull Request

Description:

  • Add an approved_at field to the Event model as the first step in allowing guests to suggest a new event.
  • Add suggestion form for unauthenticated and non-staff users to suggest a new event, requiring approval by an admin to display the event on the website
  • All existing events in the database will be automatically approved via a data migration

Related Issues:

Checklist:

  • All tests pass.
  • Code follows the project's coding standards.
  • Documentation has been updated.

@joeriddles joeriddles requested review from KGB33, davidslusser, gwimtux and a team August 15, 2024 06:54
@KGB33
Copy link
Collaborator

KGB33 commented Aug 15, 2024

When suggesting a group, is there any way to add a picker/selection widget for the duration? Like what the date field has. I ran into some confusion trying to set the duration.
image

Alternatively, displaying the expected format (DD:HH:MM?) would help too.

Also, I'm not sure if its intentional, but users can suggest events in the past.

Otherwise LGTM.
I like the Suggest Event button changing to Add Event when logged in as an admin.

Copy link
Collaborator

@KGB33 KGB33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeriddles
Copy link
Contributor Author

@KGB33 I updated to use two datetime inputs and calculate the difference between them on form save.

image

@joeriddles joeriddles requested a review from KGB33 August 24, 2024 20:30
@KGB33
Copy link
Collaborator

KGB33 commented Aug 24, 2024

@KGB33 I updated to use two datetime inputs and calculate the difference between them on form save.

image

Looks great!
I don't see it on the branch though.

@joeriddles
Copy link
Contributor Author

Looks great!

I don't see it on the branch though.

Remembering to run git push would help :)

Should be there now.

Copy link
Collaborator

@KGB33 KGB33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeriddles joeriddles merged commit bbcb7ee into main Aug 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest a new event as a guest
2 participants